NO-JIRA: OVNK BGP: improve debug and increase NNCP timeout for VRF-Lite test case#31022
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
WalkthroughRefactors test debug gathering to run once per test using Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 9 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
bot
added
the
approved
|
/testwith openshift/kubernetes/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next openshift/ovn-kubernetes#2975 |
|
@jcaamano, |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/extended/networking/route_advertisements.go`:
- Around line 142-149: The sync.Once variable gatherDebugInfoOnce is declared in
the Describe closure and therefore persists across specs, causing debug
gathering to be suppressed after the first failure; reset it at the start of
each spec by reinitializing gatherDebugInfoOnce = sync.Once{} inside the
per-spec setup (e.g., a BeforeEach or at beginning of the It/Specify) so
doGatherDebugInfoOnce and its call to gatherDebugInfo only dedupe within a
single spec rather than across the entire Describe.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 7e83441e-f9f9-46b3-935d-1d5eab40b9e3
📒 Files selected for processing (1)
test/extended/networking/route_advertisements.go
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
jcaamano
force-pushed
the
improve-vrf-lite
branch
from
4ca25a0 to
be137c5
Compare
|
/payload-job-with-prs periodic-ci-openshift-ovn-kubernetes-release-5.0-periodics-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next openshift/ovn-kubernetes#2975 |
|
@jcaamano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/546a37a0-39bf-11f1-9ba6-96af8f78063c-0 |
|
/test ? |
|
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw |
|
Scheduling required tests: |
|
/testwith openshift/ovn-kubernetes/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next openshift/ovn-kubernetes#2975 |
|
/testwith openshift/ovn-kubernetes/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next openshift/ovn-kubernetes#2975 openshift/cluster-network-operator#2945 |
1 similar comment
|
/testwith openshift/ovn-kubernetes/master/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-frr-next openshift/ovn-kubernetes#2975 openshift/cluster-network-operator#2945 |
| // cleanup the VRF-Lite configuration | ||
| defer func() { | ||
| o.Expect(func() error { | ||
| if g.CurrentSpecReport().Failed() { |
There was a problem hiding this comment.
I see both L3 and L2 VRF being tested in the same test, so we may not collect debug logs for one of it when it fails.
There was a problem hiding this comment.
just ignore me, both are invoked with g.By, so it wouldn't proceed with 2nd one when first one fails.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, pperiyasamy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle NO-JIRA: OVNK BGP: improve debug and increase NNCP timeout for VRF-Lite test case |
|
/verified by CI |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jcaamano: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
verified
|
@jcaamano: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/override ci/prow/e2e-vsphere-ovn-upi |
|
@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-vsphere-ovn-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 104e20a
into
openshift:main
|
@jcaamano: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Summary by CodeRabbit
Bug Fixes
Chores